Issue 80 createmodel

[watchtheblur]

What type of PR is this? (check all applicable)

• 🐛 Bug Fix
• ✨ Feature (e.g. API change, enhancement, addition, etc.)
• ♻️ Refactor
• 📝 Documentation
• 🔖 Release
• 🚩 Other (concerning: )

Context

Closes Issue #80

This should be merged in after #81

Other Related Tickets & Documents (as needed)

This relates to Issue #79

Implementation Details

Installed osprojects model by editing models.py, and installed app by adding osprojects to base.py. Ran migrations for osprojects

docker-compose run --rm app python ./manage.py makemigrations osprojects
docker-compose run --rm app python ./manage.py migrate

New Libraries/Dependancies Introduced (Fill out as needed)

Any new migration files added?

• 👍 yes
• 🙅 no, because they aren't needed

Did you add tests?

Code added or changed without test coverage or good reason for exemption won't be approved.

• 👍 yes
• 🙋 no, because I need help
• 🙅 no, because they aren't needed

Did you add documentation?

• 📜 readme.md
• 📜 contributing.md
• 📜 wiki entry
• 🙋 I'd like someone to help write documentation, and will file a new issue for it
• 🙅 no documentation needed

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@ca44c1f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?       32           
  Lines           ?      518           
  Branches        ?        0           
=======================================
  Hits            ?      434           
  Misses          ?       84           
  Partials        ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca44c1f...0574967. Read the comment docs.

[BethanyG]

LGTM!

1. Downloaded branch
2. Ran migrations
3. Logged into DB and verified tables were created
4. Started app and verified that no startup problems were logged.

[BethanyG]

@lpatmo - should we be merging this?

[lpatmo]

Yep! Thought I already did, sorry!

[BethanyG]

@lpatmo So I can't exactly revert this or it's associated change #81 -- but I should. This PR should not have been approved - it is missing tests!! So the next thing we need to make sure to do for this endpoint is add the tests in for this and for all other issues. I was distracted. But I won't be next time!!

[lpatmo]

lol, I didn't forget -- I honestly didn't think this PR needed tests, but then I looked up an example and it (kinda??) makes sense to me. I documented in #179!