-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder restructuring - #30 and #31 #87
Conversation
I've probably pulled this incorrectly, but Django won't start for me, and all tests are failing under this structure. Thoughts? |
@BethanyG Can you share a screenshot of the error messages you're getting? When I checked out this branch again after being in :( |
Earlier I'd thought I was only getting that after changing the top-most folder name to |
Make sure the |
@brylie Thanks! Do you have a good understanding of what needs to happen in (what I assume) |
Do a project-wide search for I'll see if I can find a more detailed guide to renaming the core folder. |
To reduce confusion, the Double-check the following files: wsgi.py
settings.py
manage.pybackend/cbv3_django_prototype/manage.py Line 28 in 7fb330a
|
* Rename project folder * Change cbv3_django_prototype references to project * Rename 'core' directory * Change references to users app * Change references to 'core' directory * Change project name to "Codebuddies" * Change path to /opt/codebuddies * Fix project path
Is this still on hold or can I remove the |
I'd like to hold this for a bit more, since we've already begun work on both a |
Yes, am afraid of that happening, since I had to do blow away the repo to see it working! I'm wondering if we can merge this in after tags and before additional work on the |
At the worst, it should only be necessary to delete and then check out the |
Another thing is that the new |
@lpatmo - do we want to hold work and bite the bullet now that tags is merged in? I was going to start work on some testing related issues, but we should get this piece done first, I think. |
There were a couple of conflicts here, and in the process of solving it I found it easier to create a new PR here: #99 The new PR should include both Brylie and Bethany's changes. If someone would be so kind as to check out the |
Update: I've merged in PR#99. Thanks again @brylie for your commits! :) |
Addresses #30 and #31.
(I also took a stab at #50, but renaming
cbv3_django_prototype
toapp
everyone broke a lot of things -- so am holding off that for now. Will share screenshot of error messages in #50.)Implementation
[x] Move all project files under the cbv3_django_prototype directory to the repository root
[x] Consider reorganizing the project, so that apps are created in the project root (rather than in the nested directory)
[x] Move all existing apps (namely,
resources
,users
, anduserauth
) to the project rootThanks @brylie for these suggestions, and @billglover and @BethanyG for reminding me I signed up to tackle them!
The app looks good (is still running heh) with these changes, so I shouldn't have broken anything. Please let me know if you noticed that I missed something.