[DEVOPS-6292] Migrate CICD from CircleCI to Github Actions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantech2000
reviewed
Aug 10, 2023
.github/workflows/lint.yaml
Outdated
| ${{ runner.os }}- | ||
|
|
||
| - name: Run Rubocop | ||
| run: bundle exec rubocop --config ./.rubocop.yml |
There was a problem hiding this comment.
LGTM only thing is the no new line at the end of the file but that might just be a yaml linting thing
mbacchi
approved these changes
Aug 10, 2023
.github/workflows/lint.yaml
Outdated
| with: | ||
| bundler-cache: true | ||
|
|
||
| - name: Cache dependencies |
There was a problem hiding this comment.
I wonder if it's even necessary to cache dependencies for a project like this which is built very rarely. (I'm also not sure how long the cache stays in place, and if it's purged automatically or if it costs money to maintain it in Github Actions' cache.)
I'll leave it up to you to decide Ana.
There was a problem hiding this comment.
I agree, we probably don't need caching on this repo. No one has touched it in ages and afaik there aren't any updates to it happening soon. We can revisit but for now I'll remove caching.
leonpham0
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://codecademy.atlassian.net/browse/DEVOPS-6292