Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ruby 1.8.7 #26

Closed
guzart opened this issue Dec 11, 2013 · 13 comments
Closed

Support for Ruby 1.8.7 #26

guzart opened this issue Dec 11, 2013 · 13 comments

Comments

@guzart
Copy link

guzart commented Dec 11, 2013

I get the following error:

codeclimate-test-reporter-0.2.0/lib/code_climate/test_reporter/formatter.rb:45
odd number list for Hash (SyntaxError)
        name:             short_filename(file.filename),

It looks like the new ruby hash syntax might be causing the issue?

as opposed to :name => short_filename(file.filename)

Thanks

@brynary
Copy link
Member

brynary commented Dec 12, 2013

Hello. Yes, the hashes would be an issue.

However, more significantly, this gem is based on SimpleCov, which only supports Ruby 1.9, to my knowledge. So it is not 1.8 compatible (and we don't plan to add support).

Thanks.

@brynary brynary closed this as completed Dec 12, 2013
@Nowaker
Copy link

Nowaker commented Jan 22, 2014

Please include this in README.md then.

@Nowaker
Copy link

Nowaker commented Jan 22, 2014

And gemspec.

@brynary
Copy link
Member

brynary commented Jan 22, 2014

@Nowaker -- Thanks. Yes, happy to. I'm not familiar with how to indicate this in a Gemspec. Do you have an example?

@Nowaker
Copy link

Nowaker commented Jan 22, 2014

@Nowaker
Copy link

Nowaker commented Mar 17, 2014

@brynary You probably missed my message.

@djones
Copy link

djones commented Mar 21, 2014

+1. Got caught out by this today.

@yagudaev
Copy link

Its nice to have, but as 1.8.7 is no longer supported by the ruby core team, I don't see why codeclimate would add support for it.

@guzart
Copy link
Author

guzart commented Jun 12, 2014

@yagudaev good point... otherwise IE6 support would be nice too.

@Nowaker
Copy link

Nowaker commented Jun 12, 2014

It's no longer supported by Ruby core team, but it IS supported. Refer to rvm/rvm#2801. Comparing Ruby 1.8 to IE 6 is a nonsense.

Nevertheless, I am not asking for 1.8 support. I'm just asking them to specify required Ruby version in gemspec. It's not that hard...

@guzart
Copy link
Author

guzart commented Jun 12, 2014

@Nowaker Let me elaborate on my comparison. Ruby 1.8.7 and IE6 are technologies that are no longer oficially supported, people might still use them. But new products need to draw a line on which technologies they will support otherwise the ROI would be very low.

I agree that they should indicate somewhere which ruby versions are supported.

You could try opening a new issue regarding the missing documentation, or even a submit PR.

@Nowaker
Copy link

Nowaker commented Aug 24, 2014

@iainbeeston
Copy link
Contributor

Sorry to resurrect an old thread, but apparently simplecov does support 1.8, but it's a no-op - simplecov-ruby/simplecov#333

I'll open a pull request to add the ruby version to the gemspec.

iainbeeston added a commit to iainbeeston/ruby-test-reporter that referenced this issue Oct 29, 2014
Fix for codeclimate#26.

SimpleCov technically does support ruby 1.8.7, but code climate does not (because it uses 1.9-style hash syntax). At least by adding this to the gemspec it's explicit to anyone wanting to use the gem (rather than them trying it and seeing errors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants