-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ruby 1.8.7 #26
Comments
Hello. Yes, the hashes would be an issue. However, more significantly, this gem is based on SimpleCov, which only supports Ruby 1.9, to my knowledge. So it is not 1.8 compatible (and we don't plan to add support). Thanks. |
Please include this in README.md then. |
And gemspec. |
@Nowaker -- Thanks. Yes, happy to. I'm not familiar with how to indicate this in a Gemspec. Do you have an example? |
Stack Overflow has got it. :) https://stackoverflow.com/questions/5004492/how-do-you-specify-a-minimum-ruby-version-in-a-gemspec |
@brynary You probably missed my message. |
+1. Got caught out by this today. |
Its nice to have, but as 1.8.7 is no longer supported by the ruby core team, I don't see why codeclimate would add support for it. |
@yagudaev good point... otherwise IE6 support would be nice too. |
It's no longer supported by Ruby core team, but it IS supported. Refer to rvm/rvm#2801. Comparing Ruby 1.8 to IE 6 is a nonsense. Nevertheless, I am not asking for 1.8 support. I'm just asking them to specify required Ruby version in gemspec. It's not that hard... |
@Nowaker Let me elaborate on my comparison. Ruby 1.8.7 and IE6 are technologies that are no longer oficially supported, people might still use them. But new products need to draw a line on which technologies they will support otherwise the ROI would be very low. I agree that they should indicate somewhere which ruby versions are supported. You could try opening a new issue regarding the missing documentation, or even a submit PR. |
@brynary Please include this in README.md and gemspec. https://stackoverflow.com/questions/5004492/how-do-you-specify-a-minimum-ruby-version-in-a-gemspec |
Sorry to resurrect an old thread, but apparently simplecov does support 1.8, but it's a no-op - simplecov-ruby/simplecov#333 I'll open a pull request to add the ruby version to the gemspec. |
Fix for codeclimate#26. SimpleCov technically does support ruby 1.8.7, but code climate does not (because it uses 1.9-style hash syntax). At least by adding this to the gemspec it's explicit to anyone wanting to use the gem (rather than them trying it and seeing errors)
I get the following error:
It looks like the new ruby hash syntax might be causing the issue?
as opposed to
:name => short_filename(file.filename)
Thanks
The text was updated successfully, but these errors were encountered: