-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ACH payment method #1083
Conversation
9f023ab
to
058e85f
Compare
Codecov ReportAttention: Patch coverage is
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 96.09% 96.08% -0.01%
==========================================
Files 829 832 +3
Lines 19384 19459 +75
==========================================
+ Hits 18627 18698 +71
- Misses 757 761 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
02cfe7f
to
fea79e0
Compare
fea79e0
to
0d80364
Compare
834f022
to
fd0f925
Compare
fd0f925
to
5301ad6
Compare
codecov_auth/commands/owner/interactors/create_stripe_setup_intent.py
Outdated
Show resolved
Hide resolved
aa6df89
to
71d2628
Compare
71d2628
to
86999ee
Compare
86999ee
to
8ea30ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Just two more minor nits
2829141
to
530136c
Compare
This PR does below to add compatibility for ACH payment method.
PaymentElement
(formerly using theCardElement
that does not require this).CheckoutSession
and the newPaymentElement
. If not specified, it uses the Default in the stripe dashboard.should_propagate
knob on the existingupdate_email
api as the ACH payment method requires an associated billing_email (where it was optional on credit card). With our UI designs, we specify email in a separate component, so have that component propagate the info to the default_payment_method using this updated api.The changes to these apis are all backwards compatible so can go in before any UI changes go live.
Part of this project: codecov/engineering-team#2622
Closes codecov/engineering-team#3115
Closes codecov/engineering-team#3114
Closes codecov/engineering-team#3110