Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update shared, remove amplitude #1125

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

Updates shared to c8dca74. Also removes amplitude as a direct dependency because it's now a dependency of shared.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review February 3, 2025 21:31
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This PR includes changes to shared. Please review them here: codecov/shared@7e9511b...c8dca74

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (8ec5b6d) to head (092dfb9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (8ec5b6d) to head (092dfb9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         837      837           
  Lines       19687    19687           
=======================================
  Hits        18916    18916           
  Misses        771      771           
Flag Coverage Δ
unit 95.99% <ø> (ø)
unit-latest-uploader 95.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit d13cceb Feb 3, 2025
19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/update-shared-c8dca74 branch February 3, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants