Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle internal server error when no GQL request body received #1134

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Feb 5, 2025

fixes: https://github.com/codecov/internal-issues/issues/1211

We get internal server error when requests are made to GQL with an empty request body "{}", this fix catches that and returns a bad requests gracefully.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (e885187) to head (7a6011f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         837      837           
  Lines       19849    19854    +5     
=======================================
+ Hits        19069    19074    +5     
  Misses        780      780           
Flag Coverage Δ
unit 95.97% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (e885187) to head (7a6011f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@JerrySentry JerrySentry marked this pull request as ready for review February 5, 2025 19:11
@JerrySentry JerrySentry requested a review from a team as a code owner February 5, 2025 19:11
@JerrySentry JerrySentry added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 54aacf3 Feb 5, 2025
19 checks passed
@JerrySentry JerrySentry deleted the feb_05_gql_no_body branch February 5, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants