fix: Review changes

codecov · Jan 17, 2025 · 7e81bba · 7e81bba
1 parent 373cd4d
commit 7e81bba
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 9 deletions.
diff --git a/src/assets/onboarding/click_here_to_install.png b/src/assets/onboarding/click_here_to_install.png
diff --git a/src/assets/onboarding/org_list_install_app.png b/src/assets/onboarding/org_list_install_app.png
diff --git a/src/layouts/BaseLayout/BaseLayout.tsx b/src/layouts/BaseLayout/BaseLayout.tsx
@@ -97,12 +97,12 @@ function BaseLayout({ children }: React.PropsWithChildren) {
         <Suspense>
           <ErrorBoundary errorComponent={<EmptyErrorComponent />}>
             <SilentNetworkErrorWrapper>
-              {(isFullExperience || isImpersonating) && (
+              {isFullExperience || isImpersonating ? (
                 <>
                   <GlobalTopBanners />
                   <Header hasRepoAccess={data?.hasRepoAccess} />
                 </>
-              )}
+              ) : null}
             </SilentNetworkErrorWrapper>
           </ErrorBoundary>
         </Suspense>
@@ -126,12 +126,12 @@ function BaseLayout({ children }: React.PropsWithChildren) {
         </Suspense>
 
         {/* Footer */}
-        {isFullExperience && (
+        {isFullExperience ? (
           <>
             <Footer />
             <ToastNotifications />
           </>
-        )}
+        ) : null}
       </RepoBreadcrumbProvider>
     </>
   )

diff --git a/src/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx b/src/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx
@@ -36,8 +36,9 @@ function OnboardingOrg() {
         <div className="flex items-center justify-center gap-6 py-8">
           <div className="h-[107px] w-[169px]">
             <img
-              src={orgListInstallApp}
               alt="GitHub Organization Install List Example"
+              className="h-full object-cover"
+              src={orgListInstallApp}
             />
           </div>
           <div className="w-[350px] text-sm">

diff --git a/src/pages/OwnerPage/OwnerPage.jsx b/src/pages/OwnerPage/OwnerPage.jsx
@@ -78,7 +78,7 @@ function OwnerPage() {
         </SilentNetworkErrorWrapper>
       </Suspense>
       <div>
-        {showOnboardingContainer && <OnboardingOrg />}
+        {showOnboardingContainer ? <OnboardingOrg /> : null}
         {ownerData?.isCurrentUserPartOfOrg && (
           <Tabs owner={ownerData} provider={provider} />
         )}

diff --git a/src/shared/AppInstallModal/AppInstallModal.tsx b/src/shared/AppInstallModal/AppInstallModal.tsx
@@ -1,4 +1,4 @@
-import clickHereToInstall from 'assets/onboarding/click_here_to_install.png'
+import clickHereToInstall from 'assets/onboarding/org_list_install_app.png'
 import Button from 'ui/Button'
 import { CodeSnippet } from 'ui/CodeSnippet'
 import Modal from 'ui/Modal'
@@ -29,11 +29,11 @@ function AppInstallModal({
             You need to install Codecov app on your GitHub organization as an
             admin.
           </span>
-          <div className="mb-5 bg-ds-gray-primary px-6 ">
+          <div className="mb-5 bg-ds-gray-primary px-6">
             <img
               src={clickHereToInstall}
               alt="click here to install screenshot"
-              className="mx-auto h-72 w-[508px] object-cover"
+              className="mx-auto h-72 w-[508px] object-contain"
             />
           </div>
           <span className="mb-2 text-sm">