Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cut over to Stripe PaymentElement #3665

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

incorporate pr comments

96caf94
Select commit
Loading
Failed to load commit list.
Open

feat: Cut over to Stripe PaymentElement #3665

incorporate pr comments
96caf94
Select commit
Loading
Failed to load commit list.
Codecov Public QA / codecov/project failed Jan 18, 2025 in 0s

98.80% (-0.12%) compared to 162b8ca

View this Pull Request on Codecov

98.80% (-0.12%) compared to 162b8ca

Details

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.80%. Comparing base (162b8ca) to head (96caf94).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 90.32% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
- Coverage   98.91%   98.80%   -0.12%     
==========================================
  Files         817      820       +3     
  Lines       14720    14783      +63     
  Branches     4165     4211      +46     
==========================================
+ Hits        14561    14607      +46     
- Misses        152      167      +15     
- Partials        7        9       +2     
Files with missing lines Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <100.00%> (ø)
...rentOrgPlan/BillingDetails/Address/AddressCard.tsx 100.00% <ø> (ø)
...lan/BillingDetails/PaymentCard/BankInformation.tsx 100.00% <100.00%> (ø)
...OrgPlan/BillingDetails/PaymentCard/PaymentCard.jsx 100.00% <100.00%> (ø)
src/services/account/useAccountDetails.ts 95.45% <100.00%> (+0.21%) ⬆️
src/services/account/useUpdatePaymentMethod.ts 95.00% <ø> (ø)
src/shared/ThemeContext/ThemeContext.tsx 96.87% <100.00%> (+0.10%) ⬆️
src/stripe.ts 100.00% <100.00%> (ø)
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 90.32% <90.32%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <92.30%> (-0.20%) ⬇️
Services 99.28% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162b8ca...96caf94. Read the comment docs.