Unify and slightly reword account deletion #3742

Swatinem · 2025-02-14T15:45:16Z

The DeletionCard was duplicated across the Profile for self hosted users, as well as the Admin for SaaS.

This now uses the same component for both, and slightly rewords the text.

Next step here would be to revert the relevant parts of #2892 to bring back the self-serve account / organization deletion.

codecov-staging · 2025-02-14T15:47:39Z

Bundle Report

Changes will decrease total bundle size by 344 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	6.26MB	-124 bytes (-0.0%) ⬇️
gazebo-staging-esm	6.31MB	-220 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	383 bytes	12.66kB	3.12%
`assets/index-legacy.*.js`	-266 bytes	5.98kB	-4.26%
`assets/index-legacy.*.js`	-801 bytes	12.28kB	-6.12%
`assets/index-legacy.*.js`	-166 bytes	13.08kB	-1.25%
*`assets/DeletionCard-legacy..js`** (New)	726 bytes	726 bytes	100.0% 🚀

Files in assets/index-legacy.*.js:

./src/pages/AccountSettings/tabs/Admin/Admin.jsx → Total Size: 1.02kB

Files in assets/index-legacy.*.js:

./src/pages/AccountSettings/tabs/Profile/Profile.jsx → Total Size: 932 bytes

Files in assets/DeletionCard-legacy.*.js:

./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 813 bytes

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	-391 bytes	12.79kB	-2.97%
`assets/index.*.js`	-68 bytes	6.2kB	-1.09%
`assets/index.*.js`	-49 bytes	13.19kB	-0.37%
`assets/index.*.js`	163 bytes	6.26kB	2.67%
`assets/index.*.js`	-149 bytes	13.23kB	-1.11%
`assets/index.*.js`	-362 bytes	6.1kB	-5.6%
*`assets/DeletionCard..js`** (New)	636 bytes	636 bytes	100.0% 🚀

Files in assets/index.*.js:

./src/pages/AccountSettings/tabs/Admin/Admin.jsx → Total Size: 1.02kB

Files in assets/index.*.js:

./src/pages/AccountSettings/tabs/Profile/Profile.jsx → Total Size: 932 bytes

Files in assets/DeletionCard.*.js:

./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 813 bytes

codecov · 2025-02-14T15:48:07Z

Bundle Report

Changes will decrease total bundle size by 344 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.26MB	-124 bytes (-0.0%) ⬇️
gazebo-production-esm	6.31MB	-220 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	-68 bytes	6.2kB	-1.09%
`assets/index.*.js`	-391 bytes	12.79kB	-2.97%
`assets/index.*.js`	-198 bytes	13.19kB	-1.48%
`assets/index.*.js`	163 bytes	6.26kB	2.67%
`assets/index.*.js`	66 bytes	6.1kB	1.09%
`assets/index.*.js`	312 bytes	6.04kB	5.45% ⚠️
`assets/index.*.js`	114 bytes	5.72kB	2.03%
`assets/index.*.js`	94 bytes	5.61kB	1.7%
`assets/index.*.js`	-917 bytes	5.52kB	-14.25%
`assets/index.*.js`	-31 bytes	6.43kB	-0.48%
*`assets/DeletionCard..js`** (New)	636 bytes	636 bytes	100.0% 🚀

Files in assets/index.*.js:

./src/pages/AccountSettings/tabs/Profile/Profile.jsx → Total Size: 932 bytes

Files in assets/index.*.js:

./src/pages/AccountSettings/tabs/Admin/Admin.jsx → Total Size: 1.02kB

Files in assets/DeletionCard.*.js:

./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 813 bytes

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	383 bytes	12.66kB	3.12%
`assets/index-legacy.*.js`	-51 bytes	5.98kB	-0.85%
`assets/index-legacy.*.js`	-215 bytes	6.03kB	-3.44%
`assets/index-legacy.*.js`	-967 bytes	12.28kB	-7.3%
*`assets/DeletionCard-legacy..js`** (New)	726 bytes	726 bytes	100.0% 🚀

Files in assets/index-legacy.*.js:

./src/pages/AccountSettings/tabs/Admin/Admin.jsx → Total Size: 1.02kB

Files in assets/index-legacy.*.js:

./src/pages/AccountSettings/tabs/Profile/Profile.jsx → Total Size: 932 bytes

Files in assets/DeletionCard-legacy.*.js:

./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 813 bytes

codecov · 2025-02-14T15:48:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (dd109a6) to head (ae33949).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         823      822       -1     
  Lines       14868    14865       -3     
  Branches     4222     4232      +10     
==========================================
- Hits        14697    14694       -3     
  Misses        165      165              
  Partials        6        6

Files with missing lines	Coverage Δ
src/pages/AccountSettings/tabs/Admin/Admin.jsx	`100.00% <ø> (ø)`
...AccountSettings/tabs/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`88.88% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.52% <100.00%> (-0.01%)`	⬇️
Services	`99.24% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd109a6...ae33949. Read the comment docs.

codecov-staging · 2025-02-14T15:48:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         823      822       -1     
  Lines       14868    14865       -3     
  Branches     4230     4232       +2     
==========================================
- Hits        14697    14694       -3     
  Misses        165      165              
  Partials        6        6

Files with missing lines	Coverage Δ
src/pages/AccountSettings/tabs/Admin/Admin.jsx	`100.00% <ø> (ø)`
...AccountSettings/tabs/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`88.88% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.52% <100.00%> (-0.01%)`	⬇️
Services	`99.24% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd109a6...ae33949. Read the comment docs.

codecov-qa · 2025-02-14T15:48:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (dd109a6) to head (ae33949).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         823      822       -1     
  Lines       14868    14865       -3     
  Branches     4222     4224       +2     
==========================================
- Hits        14697    14694       -3     
  Misses        165      165              
  Partials        6        6

Files with missing lines	Coverage Δ
src/pages/AccountSettings/tabs/Admin/Admin.jsx	`100.00% <ø> (ø)`
...AccountSettings/tabs/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`88.88% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.52% <100.00%> (-0.01%)`	⬇️
Services	`99.24% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd109a6...ae33949. Read the comment docs.

codecov-public-qa · 2025-02-14T15:48:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (dd109a6) to head (ae33949).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         823      822       -1     
  Lines       14868    14865       -3     
  Branches     4222     4232      +10     
==========================================
- Hits        14697    14694       -3     
  Misses        165      165              
  Partials        6        6

Files with missing lines	Coverage Δ
src/pages/AccountSettings/tabs/Admin/Admin.jsx	`100.00% <ø> (ø)`
...AccountSettings/tabs/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`88.88% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.52% <100.00%> (-0.01%)`	⬇️
Services	`99.24% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd109a6...ae33949. Read the comment docs.

codecov-releaser · 2025-02-14T15:50:31Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`c392709`	Fri, 14 Feb 2025 15:50:31 GMT	Expired	Expired
`ae33949`	Fri, 14 Feb 2025 15:57:41 GMT	Cloud	Enterprise

The `DeletionCard` was duplicated across the `Profile` for self hosted users, as well as the `Admin` for SaaS. This now uses the same component for both, and slightly rewords the text.

nicholas-codecov

LGTM

Swatinem requested a review from a team February 14, 2025 15:45

Swatinem self-assigned this Feb 14, 2025

Unify and slightly reword account deletion

ae33949

The `DeletionCard` was duplicated across the `Profile` for self hosted users, as well as the `Admin` for SaaS. This now uses the same component for both, and slightly rewords the text.

Swatinem force-pushed the swatinem/deletioncard branch from c392709 to ae33949 Compare February 14, 2025 15:51

This was referenced Feb 17, 2025

Reintroduce the "delete account" action #3745

Open

Revamp Delete Repo Content Workflow codecov/engineering-team#1127

Closed

nicholas-codecov approved these changes Feb 19, 2025

View reviewed changes

Swatinem added this pull request to the merge queue Feb 20, 2025

Merged via the queue into main with commit c1f92fd Feb 20, 2025
62 checks passed

Swatinem deleted the swatinem/deletioncard branch February 20, 2025 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify and slightly reword account deletion #3742

Unify and slightly reword account deletion #3742

Swatinem commented Feb 14, 2025

codecov-staging bot commented Feb 14, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov bot commented Feb 14, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov bot commented Feb 14, 2025 •

edited

Loading

codecov-staging bot commented Feb 14, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Feb 14, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 14, 2025 •

edited

Loading

codecov-releaser commented Feb 14, 2025 •

edited

Loading

nicholas-codecov left a comment

Unify and slightly reword account deletion #3742

Unify and slightly reword account deletion #3742

Conversation

Swatinem commented Feb 14, 2025

codecov-staging bot commented Feb 14, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov bot commented Feb 14, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov bot commented Feb 14, 2025 • edited Loading

Codecov Report

codecov-staging bot commented Feb 14, 2025 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Feb 14, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Feb 14, 2025 • edited Loading

Codecov Report

codecov-releaser commented Feb 14, 2025 • edited Loading

✅ Deploy preview for gazebo ready!

nicholas-codecov left a comment

Choose a reason for hiding this comment

codecov-staging bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading

codecov-staging bot commented Feb 14, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Feb 14, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 14, 2025 •

edited

Loading

codecov-releaser commented Feb 14, 2025 •

edited

Loading