Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pro plan via Migration #495

Merged
merged 14 commits into from
Feb 7, 2025
Merged

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Jan 31, 2025

This PR seeds the existing pro plan to the DB so we can use it for DEC and self-hosted by default. It also updates all owners to that plan. The migration only runs the logic if the env is enterprise.

In the process we're also creating a new variable which will set the default plan name for an owner to be the pro plan if they're enterprise so they can avoid having to create a bunch of other plans in their DB.

Screenshot 2025-02-05 at 1 59 06 PM Screenshot 2025-02-05 at 2 00 13 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (93e7d29) to head (c12d9bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   90.39%   89.97%   -0.43%     
==========================================
  Files         444      324     -120     
  Lines       13031     9045    -3986     
  Branches     2109     1599     -510     
==========================================
- Hits        11780     8138    -3642     
+ Misses       1131      846     -285     
+ Partials      120       61      -59     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@nora-codecov nora-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that one thing about using .update() but that's not a showstopper

@ajay-sentry ajay-sentry added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit abf6180 Feb 7, 2025
6 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/add-pro-plan-via-migration branch February 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants