-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pro plan via Migration #495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 90.39% 89.97% -0.43%
==========================================
Files 444 324 -120
Lines 13031 9045 -3986
Branches 2109 1599 -510
==========================================
- Hits 11780 8138 -3642
+ Misses 1131 846 -285
+ Partials 120 61 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that one thing about using .update() but that's not a showstopper
This PR seeds the existing pro plan to the DB so we can use it for DEC and self-hosted by default. It also updates all owners to that plan. The migration only runs the logic if the env is enterprise.
In the process we're also creating a new variable which will set the default plan name for an owner to be the pro plan if they're enterprise so they can avoid having to create a bunch of other plans in their DB.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.