perf: use lpop with count and don't fetch upload in Upload task

[joseph-sentry]

we don't need to fetch the report upload because all we're doing is setting the upload_pk to upload_id in the normalized args dict

we also can batch our redis lpops into groups of 50 so we don't have to make as many calls to redis

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/upload.py

Function	Unhandled Issue
run_impl_within_lock	MaxRetriesExceededError: Can't retry app.tasks.upload.Upload[fd6a0ae8-01f2-49af-bf6c-c8f1c0e2d30b] args:() kwargs:{'debug'... ... Event Count: 1

---

_{Did you find this useful? React with a 👍 or 👎}

[codecov-notifications]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files	Patch %	Lines
tasks/tests/unit/test_upload_task.py	75.00%	3 Missing ⚠️

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.02%     
==========================================
  Files         434      434              
  Lines       36607    36616       +9     
==========================================
+ Hits        35911    35916       +5     
- Misses        696      700       +4     

Flag	Coverage Δ
integration	98.08% <82.35%> (-0.02%)	⬇️
latest-uploader-overall	98.08% <82.35%> (-0.02%)	⬇️
unit	98.08% <82.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.01% <100.00%> (-0.01%)	⬇️
OutsideTasks	98.10% <ø> (-0.01%)	⬇️

Files	Coverage Δ
tasks/upload.py	96.34% <100.00%> (+0.01%)	⬆️
tasks/tests/unit/test_upload_task.py	99.09% <75.00%> (-0.45%)	⬇️

... and 1 file with indirect coverage changes

[codecov-qa]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.08%. Comparing base (e867451) to head (de6065a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
tasks/tests/unit/test_upload_task.py	75.00%	3 Missing ⚠️

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.02%     
==========================================
  Files         434      434              
  Lines       36607    36616       +9     
==========================================
+ Hits        35911    35916       +5     
- Misses        696      700       +4     

Flag	Coverage Δ
integration	98.08% <82.35%> (-0.02%)	⬇️
latest-uploader-overall	98.08% <82.35%> (-0.02%)	⬇️
unit	98.08% <82.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.01% <100.00%> (-0.01%)	⬇️
OutsideTasks	98.10% <ø> (-0.01%)	⬇️

Files with missing lines	Coverage Δ
tasks/upload.py	96.34% <100.00%> (+0.01%)	⬆️
tasks/tests/unit/test_upload_task.py	99.09% <75.00%> (-0.45%)	⬇️

... and 1 file with indirect coverage changes

[codecov-public-qa]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.08%. Comparing base (e867451) to head (de6065a).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.02%     
==========================================
  Files         434      434              
  Lines       36607    36616       +9     
==========================================
+ Hits        35911    35916       +5     
- Misses        696      700       +4     

Flag	Coverage Δ
integration	98.08% <82.35%> (-0.02%)	⬇️
latest-uploader-overall	98.08% <82.35%> (-0.02%)	⬇️
unit	98.08% <82.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.01% <100.00%> (-0.01%)	⬇️
OutsideTasks	98.10% <ø> (-0.01%)	⬇️

Files	Coverage Δ
tasks/upload.py	96.34% <100.00%> (+0.01%)	⬆️
tasks/tests/unit/test_upload_task.py	99.09% <75.00%> (-0.45%)	⬇️

... and 1 file with indirect coverage changes

[codecov]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.13%. Comparing base (e867451) to head (de6065a).
Report is 4 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
tasks/tests/unit/test_upload_task.py	75.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   98.14%   98.13%   -0.01%     
==========================================
  Files         475      475              
  Lines       37962    37971       +9     
==========================================
+ Hits        37257    37263       +6     
- Misses        705      708       +3     

Flag	Coverage Δ
integration	98.08% <82.35%> (-0.02%)	⬇️
latest-uploader-overall	98.08% <82.35%> (-0.02%)	⬇️
unit	98.08% <82.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.11% <100.00%> (+<0.01%)	⬆️
OutsideTasks	98.10% <ø> (-0.01%)	⬇️

Files with missing lines	Coverage Δ
tasks/upload.py Critical	97.68% <100.00%> (+<0.01%)	⬆️
tasks/tests/unit/test_upload_task.py	99.09% <75.00%> (-0.45%)	⬇️

Related Entrypoints
run/app.tasks.upload.Upload

[Swatinem]

looks great!