Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No social media links #6

Open
oohwooh opened this issue Aug 4, 2021 · 6 comments
Open

No social media links #6

oohwooh opened this issue Aug 4, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@oohwooh
Copy link
Member

oohwooh commented Aug 4, 2021

No description provided.

@oohwooh oohwooh self-assigned this Aug 4, 2021
@oohwooh oohwooh added the enhancement New feature or request label Aug 4, 2021
@yednapg
Copy link

yednapg commented Dec 5, 2022

Hey, @tylermenezes I can try this. Just give me a brief overview of where to place the links and whether we have to use icons or text.

@tylermenezes
Copy link
Member

You're welcome to do it however you want, but I think icons might be nice! As long as we have the legal right to use them.

If you want it to show up on all our websites you could add it to Organism/Footer in the "topo" repository which is used on all our sites.

@yednapg
Copy link

yednapg commented Feb 22, 2023

Hey Tyler, Before I started coding, I tried designing the footer with social media icons from Canva. I would love to hear any feedback you have on it.

We can move the legal documents to the resources section.

CodeDay-Footer-Social-Media

@yednapg
Copy link

yednapg commented Feb 22, 2023

About having the legal right to use them. What if we use React Icons? They are under CC BY 4.0 License.

@tylermenezes
Copy link
Member

I like this! Of course we can rename "More" to "Social" or something like that.

React Icons or anything else is fine but let's just import the 4 SVGs themselves instead of using the entire icon library, since this would make the page sizes much larger.

@yednapg
Copy link

yednapg commented Mar 16, 2023

#10 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants