added socials #10
Closed
added socials #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yednapg is attempting to deploy a commit to the CodeDay Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@oohwooh do you think we should just add these (and move into the right column) in Topo so it works on all sites? |
|
I think having this in topo instead would be good. Also want to make sure we are not violating any licenses by using these icons |
|
Maybe we could also pull this social information from contentful? That way we don't need to go around and bump packages any time we want to change something. Would be especially helpful given our tendency to introduce breaking changes regularly in topo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just added four social links to the homepage! However, since there are different links for Clear and Corp, I don't think it's the best idea to add them to the topo for now. I removed the
https://www.codeday.org/docslink from the footer's More section. Should I add it to the footer's Resources section in topo?