Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 #47

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Node 18 #47

merged 2 commits into from
Jan 10, 2023

Conversation

ct-jahidhasan
Copy link
Member

@ct-jahidhasan ct-jahidhasan commented Dec 14, 2022

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Follow project directory structure
  • To create any new page follow our sample page or any other page
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style/sx follow our pre-built components/elements (use the minimum number of sx styles)
  • For the main section use the Grid component and for the sub-section - use the Stack component
  • Check all files changed by you in vs code and only commit needed once
  • When you rename file or directory, use the command code (don't rename pushed files manually)

@ct-jahidhasan
Copy link
Member Author

found some eslint warnings from previous changes

@phoenixcoded20 phoenixcoded20 requested a review from ct-amit January 5, 2023 05:20
@phoenixcoded20 phoenixcoded20 merged commit 8e1bf97 into main Jan 10, 2023
@phoenixcoded20 phoenixcoded20 deleted the node_18 branch January 10, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants