Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codeforamerica/honeycrisp-gem
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.2
Choose a base ref
...
head repository: codeforamerica/honeycrisp-gem
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.10.3
Choose a head ref
  • 6 commits
  • 11 files changed
  • 4 contributors

Commits on Jun 18, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    0537424 View commit details

Commits on Jul 26, 2021

  1. Upgrade axe-matchers to axe-core-rspec

    [#267]
    
    Co-authored-by: Ben Golder <[email protected]>
    Colt Borg and bengolder committed Jul 26, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    8578a64 View commit details

Commits on Aug 3, 2021

  1. Update issue templates

    bengolder authored Aug 3, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f84fb7d View commit details
  2. Update issue templates

    bengolder authored Aug 3, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9552b29 View commit details

Commits on Aug 4, 2021

  1. Fix reveal and add tests (#281)

    * Fix reveal and add tests
    - Closes #275
    cy-by authored Aug 4, 2021

    Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    7e71f61 View commit details
  2. Release honeycrisp-gem v0.10.3

    Colt Borg committed Aug 4, 2021
    Copy the full SHA
    d8f4051 View commit details
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/inclusivity-scoring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Inclusivity Scoring
about: "[short term] for making new inclusivity scoring tasks "
title: 'Reveal: score'
labels: inclusivity-score
assignees: ''

---

Have we checked ___ about [reveals](http://honeycrisp.herokuapp.com/cfa/styleguide#molecules-reveal)?

Acceptance criteria:

- document a score of [unchecked] / [checked and looked good] / [checked and had issues]
- document notes of your process and how you got the score, so that we can reflect on our approach to this score.
20 changes: 19 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Changelog

## [v0.10.3](https://github.com/codeforamerica/honeycrisp-gem/tree/v0.10.3) (2021-08-04)

[Full Changelog](https://github.com/codeforamerica/honeycrisp-gem/compare/v0.10.2...v0.10.3)

**Fixed bugs:**

- Fix reveal component [\#275](https://github.com/codeforamerica/honeycrisp-gem/issues/275)
- Fix reveal and add tests [\#281](https://github.com/codeforamerica/honeycrisp-gem/pull/281) ([coltborg](https://github.com/coltborg))

**Closed issues:**

- Update axe-matchers to axe-core-gems [\#267](https://github.com/codeforamerica/honeycrisp-gem/issues/267)

**Merged pull requests:**

- Upgrade axe-matchers to axe-core-rspec [\#269](https://github.com/codeforamerica/honeycrisp-gem/pull/269) ([coltborg](https://github.com/coltborg))
- update readme to specify 'main' as the branch name [\#268](https://github.com/codeforamerica/honeycrisp-gem/pull/268) ([fionatagious](https://github.com/fionatagious))

## [v0.10.2](https://github.com/codeforamerica/honeycrisp-gem/tree/v0.10.2) (2021-05-17)

[Full Changelog](https://github.com/codeforamerica/honeycrisp-gem/compare/v0.10.1...v0.10.2)
@@ -43,6 +61,7 @@
- Namespace honeycrisp SCSS files for easy overrides [\#261](https://github.com/codeforamerica/honeycrisp-gem/pull/261) ([hartsick](https://github.com/hartsick))
- Add arrow icons for sortable headers [\#259](https://github.com/codeforamerica/honeycrisp-gem/pull/259) ([tdooner](https://github.com/tdooner))
- Consolidate max width logic [\#255](https://github.com/codeforamerica/honeycrisp-gem/pull/255) ([bytheway875](https://github.com/bytheway875))
- Create a single build-and-release command [\#245](https://github.com/codeforamerica/honeycrisp-gem/pull/245) ([bensheldon](https://github.com/bensheldon))

## [v0.9.6](https://github.com/codeforamerica/honeycrisp-gem/tree/v0.9.6) (2021-03-02)

@@ -121,7 +140,6 @@

**Merged pull requests:**

- Create a single build-and-release command [\#245](https://github.com/codeforamerica/honeycrisp-gem/pull/245) ([bensheldon](https://github.com/bensheldon))
- Upgrade percy agent, associated js dependencies, and nokogiri to appease dependabot [\#234](https://github.com/codeforamerica/honeycrisp-gem/pull/234) ([tgrathwell](https://github.com/tgrathwell))
- vendorize `neat` 1.8.0 to relax dependency on old thor [\#233](https://github.com/codeforamerica/honeycrisp-gem/pull/233) ([tgrathwell](https://github.com/tgrathwell))
- Fix - Readd incrementer.init\(\) [\#231](https://github.com/codeforamerica/honeycrisp-gem/pull/231) ([sree-cfa](https://github.com/sree-cfa))
26 changes: 17 additions & 9 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
cfa-styleguide (0.10.2)
cfa-styleguide (0.10.3)
autoprefixer-rails
bourbon
jquery-rails
@@ -57,9 +57,16 @@ GEM
ast (2.4.1)
autoprefixer-rails (10.2.4.0)
execjs
axe-matchers (2.2.1)
dumb_delegator (~> 0.8)
virtus (~> 1.0)
axe-core-api (4.2.1)
capybara
dumb_delegator
selenium-webdriver
virtus
watir
axe-core-rspec (4.2.1)
axe-core-api
dumb_delegator
virtus
axiom-types (0.1.1)
descendants_tracker (~> 0.0.4)
ice_nine (~> 0.11.0)
@@ -89,8 +96,7 @@ GEM
thread_safe (~> 0.3, >= 0.3.1)
diff-lcs (1.4.4)
dotenv (2.7.6)
dumb_delegator (0.8.1)
equalizer (0.0.11)
dumb_delegator (1.0.0)
erubi (1.10.0)
execjs (2.7.0)
faraday (1.3.0)
@@ -258,11 +264,13 @@ GEM
uglifier (4.2.0)
execjs (>= 0.3.0, < 3)
unicode-display_width (1.4.1)
virtus (1.0.5)
virtus (2.0.0)
axiom-types (~> 0.1)
coercible (~> 1.0)
descendants_tracker (~> 0.0, >= 0.0.3)
equalizer (~> 0.0, >= 0.0.9)
watir (6.19.1)
regexp_parser (>= 1.2, < 3)
selenium-webdriver (>= 3.142.7)
websocket-driver (0.7.3)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
@@ -273,7 +281,7 @@ PLATFORMS
ruby

DEPENDENCIES
axe-matchers (~> 2.2)
axe-core-rspec (~> 4.2.1)
bundler (~> 1.16)
capybara
capybara-selenium
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ If you have any thoughts or questions about the project, get in touch at <a href
Add this line to your application's Gemfile:

```ruby
gem 'cfa-styleguide', git: 'https://github.com/codeforamerica/honeycrisp-gem'
gem 'cfa-styleguide', git: 'https://github.com/codeforamerica/honeycrisp-gem', branch: :main
```

And then execute:
4 changes: 2 additions & 2 deletions app/assets/javascripts/honeycrisp.js
Original file line number Diff line number Diff line change
@@ -138,10 +138,10 @@ var revealer = (function() {
init: function() {
$('.reveal').each(function(index, revealer) {
var self = revealer;
$(self).addClass('is-hidden');
$(self).addClass('is-hiding-content');
$(self).find('.reveal__link').click(function(e) {
e.preventDefault();
$(self).toggleClass('is-hidden');
$(self).toggleClass('is-hiding-content');
});
});
}
2 changes: 1 addition & 1 deletion app/assets/stylesheets/honeycrisp/molecules/_reveal.scss
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

.reveal {
margin-bottom: 1em;
&.is-hidden {
&.is-hiding-content {
.reveal__link {
&:after {
content: '\a0'+map_get($icons, keyboard_arrow_right);
2 changes: 1 addition & 1 deletion cfa-styleguide.gemspec
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency "bourbon"
spec.add_runtime_dependency "jquery-rails"
spec.add_runtime_dependency "sass"
spec.add_development_dependency "axe-matchers", "~> 2.2"
spec.add_development_dependency "axe-core-rspec", "~> 4.2.1"
spec.add_development_dependency "bundler", "~> 1.16"
spec.add_development_dependency "capybara"
spec.add_development_dependency "capybara-selenium"
2 changes: 1 addition & 1 deletion lib/cfa/styleguide/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Cfa
module Styleguide
VERSION = "0.10.2".freeze
VERSION = "0.10.3".freeze
end
end
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

require File.expand_path("test_app/config/environment.rb", __dir__)
require "rspec/rails"
require "axe/rspec"
require "axe-rspec"

Rails.backtrace_cleaner.remove_silencers!

21 changes: 8 additions & 13 deletions spec/system/accessibility_spec.rb
Original file line number Diff line number Diff line change
@@ -11,34 +11,29 @@
].freeze

## Examples with accessibility issues that must be fixed in the fullness of time
FIXABLE_ACCESSIBILITY_EXAMPLES = [
FAILING_ACCESSIBILITY_EXAMPLES = [
"form_builder/v1/cfa_checkbox_set",
"form_builder/v1/cfa_checkbox_set_with_none",
"form_builder/v1/cfa_date_select",
"form_builder/v1/cfa_input_field",
"form_builder/v1/cfa_radio_set",
"form_builder/v1/cfa_radio_set_with_follow_up",
"form_builder/v1/cfa_range_field",
"form_builder/v1/cfa_select",
"form_builder/v1/cfa_textarea",
"molecules/form_group",
"molecules/form_group_error_state",
"molecules/incrementer",
"molecules/inline_input_group",
"molecules/searchbar",
"molecules/text_input_group",
"molecules/two_up_input_group",
# New issues coming from axe-core-rspec upgrade
"molecules/progress_step_bar",
"molecules/show_more",
"organisms/pagination",
].freeze

RSpec.describe "Acessibility", js: true do
RSpec.describe "Accessibility", js: true do
each_example do |example, example_path|
describe example do
it "passes Axe matchers" do
pending("temporarily ignoring accessibility checks") if FIXABLE_ACCESSIBILITY_EXAMPLES.include?(example)
pending("temporarily ignoring accessibility checks: #{example}") if FAILING_ACCESSIBILITY_EXAMPLES.include?(example)

visit example_path

expect(page).to be_accessible.skipping(*GENERAL_ACCESSIBILITY_SKIPS)
expect(page).to be_axe_clean.skipping(*GENERAL_ACCESSIBILITY_SKIPS).according_to :wcag2a
end
end
end
33 changes: 33 additions & 0 deletions spec/system/reveal_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
require "spec_helper"

# TODO: refactor to smaller feature spec when we add Jest JavaScript unit tests
describe "Reveal" do
before do
visit "cfa/styleguide/examples/molecules/reveal"
end

describe "default view" do
it "on page load, trigger is visible and content is not", js: true do
expect(page).to have_content "Learn more about student eligibility"
expect(page).not_to have_content "In order to qualify as a college student, you have to meet one of the following exemptions:"
end
end

describe "show reveal content" do
it "reveals content when the reveal link is clicked", js: true do
click_on "Learn more about student eligibility"

expect(page).to have_content "In order to qualify as a college student, you have to meet one of the following exemptions:"
expect(page).to have_content "Work an average at least 20 hours a week"
end
end

describe "hide reveal content" do
it "hides content when the reveal link is clicked with content already showing", js: true do
click_on "Learn more about student eligibility"
click_on "Learn more about student eligibility"

expect(page).not_to have_content "In order to qualify as a college student, you have to meet one of the following exemptions:"
end
end
end