Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reveal and add tests #281

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Fix reveal and add tests #281

merged 2 commits into from
Aug 4, 2021

Conversation

cy-by
Copy link
Contributor

@cy-by cy-by commented Aug 4, 2021

What does this PR do?

  • Changes reveal class is-hidden to is-hiding-content
  • Adds a test suite for the reveal component
  • Closes Fix reveal component #275

@cy-by cy-by added the bug Something isn't working label Aug 4, 2021
@cy-by cy-by self-assigned this Aug 4, 2021
@hartsick hartsick temporarily deployed to honeycrisp-fix-reveal-f-2w2eob August 4, 2021 17:55 Inactive

describe "default view" do
it "on page load, trigger is visible and content is not", js: true do
expect(page).to have_content "Learn more about student eligibility"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an additional assertion about not showing the content

Copy link
Contributor

@bengolder bengolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hartsick hartsick temporarily deployed to honeycrisp-fix-reveal-f-2w2eob August 4, 2021 18:29 Inactive
@cy-by cy-by merged commit 7e71f61 into main Aug 4, 2021
@cy-by cy-by deleted the fix-reveal-fully-hidden#275 branch August 4, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix reveal component
3 participants