Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teal primary button fails accessibility contrast check #18

Closed
hartsick opened this issue Nov 1, 2018 · 1 comment
Closed

Teal primary button fails accessibility contrast check #18

hartsick opened this issue Nov 1, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hartsick
Copy link
Contributor

hartsick commented Nov 1, 2018

In setting up accessibility specs on Colorado, I ran into a contrast-related failure on primary buttons in teal (.button--primary). Currently the buttons look like this (and have a ratio of 3.44):

screen shot 2018-11-01 at 1 51 34 pm

The middle button is the one failing our contrast tests at the moment, though suspect at least the smaller button is, as well.

Here's the page that describes the failure we experienced, and has some tools to try things out to improve the contrast: https://dequeuniversity.com/rules/axe/2.3/color-contrast?application=axeAPI

hartsick added a commit that referenced this issue Nov 1, 2018
@hartsick hartsick self-assigned this Nov 1, 2018
@hartsick hartsick added the bug Something isn't working label Nov 1, 2018
hartsick added a commit that referenced this issue Nov 1, 2018
hartsick added a commit that referenced this issue Nov 1, 2018
@hartsick
Copy link
Contributor Author

hartsick commented Nov 1, 2018

All merged in! Here's the relevant PR: #19

@hartsick hartsick closed this as completed Nov 1, 2018
hartsick added a commit that referenced this issue Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant