Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center content for document pages #272

Closed
bengolder opened this issue Jul 30, 2021 · 2 comments
Closed

Center content for document pages #272

bengolder opened this issue Jul 30, 2021 · 2 comments
Assignees
@cy-by
Labels
external shiba Work on codeforamerica/shiba that relates to Honeycrisp upgrade-all-apps Upgrade SHIBA, GYR, & GCF to the latest version of Honeycrisp

Comments

@bengolder
Copy link
Contributor

For upload documents and document recommendation, card is moved over and not centered

Small style discrepancy we encountered when upgrading SHIBA to the latest version of Honeycrisp

Percy failures
@bengolder bengolder added external shiba Work on codeforamerica/shiba that relates to Honeycrisp upgrade-all-apps Upgrade SHIBA, GYR, & GCF to the latest version of Honeycrisp labels Jul 30, 2021
@cy-by cy-by self-assigned this Aug 23, 2021
@cy-by
Copy link
Contributor

cy-by commented Aug 23, 2021 •
edited
Loading

This is happening because .grid-ignore-mobile doesn't have margin-left: auto; margin-right: auto; defined anymore.

I think it has something to do with neat being pulled out and placed in the vendor folder.

@cy-by
Copy link
Contributor

cy-by commented Aug 24, 2021

Page was not centering correctly because .grid-ignore-mobile was used only in SHIBA and not Honeycrisp. To fix the issue we added .grid-ignore-mobile to the css file in SHIBA.
Custom code originally in honeycrisp.css that we moved to shiba.css

@cy-by cy-by mentioned this issue Aug 24, 2021
Merged
7 tasks
@cy-by cy-by closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cy-by cy-by

Labels
external shiba Work on codeforamerica/shiba that relates to Honeycrisp upgrade-all-apps Upgrade SHIBA, GYR, & GCF to the latest version of Honeycrisp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bengolder @cy-by