Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update honeycrisp static assets to v0.10.4 #330

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

cy-by
Copy link
Contributor

@cy-by cy-by commented Jul 27, 2021

What does this PR do?

Changes to support latest version

Because of either new things in Honeycrisp or custom things in SHIBA, these adjustments need to be made:

Visual differences kept

In the latest build in Percy for this PR, Material Icons moved vertically a little bit because of a Honeycrisp change. After looking at the change, it looked like these icons looked better with the alignment. My recommendation is that we leave the icon alignment change and approve the changes in Percy. I'm happy to discuss the options for this though.

For example:

Before

before

After

after

@cy-by cy-by self-assigned this Jul 27, 2021
@bencalegari
Copy link
Contributor

@coltborg Is the idea here for us to go through/pair on the checklist items then merge the changes?

@cy-by
Copy link
Contributor Author

cy-by commented Jul 28, 2021

@bencalegari Right now I'm working on getting a draft PR in all repos (SHIBA/GCF/GYR) and then doing what we need to do to get them merged in. For SHIBA, I'm working on getting my local IntelliJ (need a license) setup so I can investigate the CSS in app locally.

@cy-by cy-by force-pushed the update-honeycrisp-to-latest branch 3 times, most recently from da079bc to 831439c Compare August 25, 2021 17:13
- update hourly wage width
- added `.grid-ignore-mobile` to keep cards centered
- added custom svg icon class for svg icon positioning
- added `.logo` overrides for psuedo states
- on `docRecommendations` keep reveal open with page script

Co-authored-by: Maria Quadri  <[email protected]>
Co-authored-by: Ben Golder <[email protected]>
@cy-by cy-by force-pushed the update-honeycrisp-to-latest branch from 831439c to 5256baf Compare August 25, 2021 22:53
@cy-by cy-by changed the title Update honeycrisp static assets to v0.10.2 Update honeycrisp static assets to v0.10.4 Aug 25, 2021
@cy-by cy-by marked this pull request as ready for review August 26, 2021 22:30
@cy-by
Copy link
Contributor Author

cy-by commented Aug 26, 2021

@bencalegari, this PR is now ready for review from a SHIBA engineer. I'd be happy to pair with them or answer any questions.

@bencalegari
Copy link
Contributor

@coltborg I did notice this change to clicked links where it becomes pretty low contrast. On staging, there's no change to the color of links that haven't been clicked. We could overwrite this pretty easily but figured I'd mention it.

Screen Shot 2021-08-27 at 1 32 35 PM

@cy-by
Copy link
Contributor Author

cy-by commented Aug 27, 2021

@coltborg I did notice this change to clicked links where it becomes pretty low contrast. On staging, there's no change to the color of links that haven't been clicked. We could overwrite this pretty easily but figured I'd mention it.

Screen Shot 2021-08-27 at 1 32 35 PM

Good catch!

I looks like links that aren't in the footer, have the :visited rule overridden in shiba.css.

I propose that I add a visited rule for the footer links so that the contrast is better. I'll keep it still AAA, but slightly darker than its existing white color.

Screen Shot 2021-08-27 at 3 44 29 PM

@bencalegari
Copy link
Contributor

Looks great, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants