-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update honeycrisp static assets to v0.10.4 #330
Conversation
@coltborg Is the idea here for us to go through/pair on the checklist items then merge the changes? |
@bencalegari Right now I'm working on getting a draft PR in all repos (SHIBA/GCF/GYR) and then doing what we need to do to get them merged in. For SHIBA, I'm working on getting my local IntelliJ (need a license) setup so I can investigate the CSS in app locally. |
da079bc
to
831439c
Compare
- update hourly wage width - added `.grid-ignore-mobile` to keep cards centered - added custom svg icon class for svg icon positioning - added `.logo` overrides for psuedo states - on `docRecommendations` keep reveal open with page script Co-authored-by: Maria Quadri <[email protected]> Co-authored-by: Ben Golder <[email protected]>
831439c
to
5256baf
Compare
@bencalegari, this PR is now ready for review from a SHIBA engineer. I'd be happy to pair with them or answer any questions. |
Good catch! I looks like links that aren't in the footer, have the I propose that I add a visited rule for the footer links so that the contrast is better. I'll keep it still |
Looks great, thanks!!! |
What does this PR do?
rake assets:package
task.Changes to support latest version
Because of either new things in Honeycrisp or custom things in SHIBA, these adjustments need to be made:
reveal
in "Document Recommendation" closed, when it is open in themain
screenshot? -> Documented in Honeycrisp Issue 286Visual differences kept
In the latest build in Percy for this PR, Material Icons moved vertically a little bit because of a Honeycrisp change. After looking at the change, it looked like these icons looked better with the alignment. My recommendation is that we leave the icon alignment change and approve the changes in Percy. I'm happy to discuss the options for this though.
For example:
Before
After