Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified step-bar-description #113

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Jun 28, 2019

because the current way is unconducive for Chinese translations

@hartsick hartsick temporarily deployed to cfa-styleguide-pr-113 June 28, 2019 23:58 Inactive
@embarnard embarnard requested a review from tdooner June 28, 2019 23:58
Copy link
Contributor

@hartsick hartsick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Gives us more flexibility for translations~~

@embarnard can you look into those test failures before merging?

@embarnard embarnard changed the title Simplified step-bar-description because the current way is unconducive for Chinese translations Simplified step-bar-description Jul 1, 2019
@embarnard embarnard merged commit 56f1235 into master Jul 1, 2019
@hartsick hartsick deleted the simplify-step-progress-bar-description branch November 14, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants