Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from <button> to <a> elements for pagination #153

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Change from <button> to <a> elements for pagination #153

merged 1 commit into from
Dec 18, 2019

Conversation

lkogler
Copy link
Contributor

@lkogler lkogler commented Dec 17, 2019

Closes #149

Co-authored-by: Ben Sheldon [email protected]

@hartsick hartsick temporarily deployed to honeycrisp-change-pagin-dorkza December 17, 2019 19:53 Inactive
@lkogler lkogler requested a review from jenny-heath December 17, 2019 19:57
bengolder
bengolder approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@bengolder bengolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lkogler lkogler merged commit d7a4747 into master Dec 18, 2019
@lkogler lkogler deleted the change-pagination-markup branch December 18, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengolder bengolder bengolder approved these changes

@jenny-heath jenny-heath Awaiting requested review from jenny-heath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for pagination HTML should show links, not buttons
3 participants
@lkogler @bengolder @hartsick