Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identifier to return a path for desired template. #178

Merged
merged 1 commit into from
May 21, 2020

Conversation

anule
Copy link
Contributor

@anule anule commented Apr 15, 2020

Rails 6 no longer returns a path when inspecting an Action View template, which causes the style guide pages to break in Rails 6 apps. This change addresses that and restores access to the Honeycrisp pages.

…ate. Use `identifier` to return a path to desired template.
@hartsick hartsick temporarily deployed to honeycrisp-fix-broken-p-dyrok5 April 15, 2020 21:49 Inactive
@luigi
Copy link
Contributor

luigi commented Apr 15, 2020

Does this fix make the styleguide pages available in a Rails 6 app?

@anule
Copy link
Contributor Author

anule commented Apr 15, 2020

Does this fix make the styleguide pages available in a Rails 6 app?

@luigi Yes. Though, there are some additional changes we had to make in the DAFI codebase to make it work fully. Renaming as a draft PR for now while I document those changes. Turns out those changes were unique to our code, so it should work more generally. You may have to do some extra configuration, but those changes should be suggested in the error screen when visiting $APP/cfa/styleguide

@anule anule changed the title Use identifier to return a path to desired template. DRAFT: Use identifier to return a path for desired template. Apr 15, 2020
@anule anule changed the title DRAFT: Use identifier to return a path for desired template. Use identifier to return a path for desired template. Apr 15, 2020
@SymonneSingleton
Copy link
Contributor

Laura and I verified that this PR works on CMR's illinois-petition-service, which uses Rails 6 as well. Looks good to us! We did have to add link calfresh_logo.png to our manifest.js, which was suggested in the rails error.

@SymonneSingleton SymonneSingleton merged commit 506699b into master May 21, 2020
@SymonneSingleton SymonneSingleton deleted the fix-broken-path-finder-in-rails-6 branch May 21, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants