Material icon font #190
Merged
Material icon font #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa, looks like percy caught a real issue with this change -- some of the icons nested in other components are broken! Will need to investigate and resolve before merging. |
- PARTIALLY fixes issue #154 - should investigate ligatures as an option in the future Co-authored-by: Symonne Singleton <[email protected]>
- Added `$icons` as variables in `_variables.rb` Fixes issue #154 Co-authored-by: Symonne Singleton <[email protected]>
The `project-icons` map is aan optional parameter in the icons mixin. This map, which can be added to a project's custom SCSS file, can be used to add icons that do not currently exist in the Honeycrisp library. Co-authored-by: Symonne Singleton <[email protected]>
* Information on how to use an icon if we don't have a predefined class for it
- replace direct usages of character codepoint with variables - fix $font-icon variable value and use it everywhere we set the icon font-family - Adjust margin-top on .flash__message .flash--error because the warning icon was appearing too high with new icon set - Set visited color on flash message dismiss button so it doesn't change color once it has been "visited"
lkogler
force-pushed
the
material-icon-font
branch
from
ada2093 to
90a5a97
Compare
|
Can you take a look at the Percy diffs @racheledelman ? It looks like the material icon font generally renders a couple pixels higher up than the old font. I'm not sure how much you care about the difference. It could be time consuming to fix, but we can do that if you feel it's important. |
|
Hm, I would like to fix that, sorry! We'll need to be able to align icons with texts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #154