Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @percy/agent to @percy/cli #297

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Update @percy/agent to @percy/cli #297

merged 1 commit into from
Sep 14, 2021

Conversation

cy-by
Copy link
Contributor

@cy-by cy-by commented Sep 14, 2021

Relates to #296

What does this PR do?

Upgrades @percy/agent to @percy/cli (and updates percy-capybara) as to remove the dependency of axios

Testing

Checking to see if the Percy build step in this PR passes with the migration change.

Dependencies resolved after this PR is merged

After merging this PR, these security issues should be removed or resolved:

- This remove axios dependency
- @percy/agent is being deprecated anyway
@cy-by cy-by added the dependencies Pull requests that update a dependency file label Sep 14, 2021
@cy-by cy-by self-assigned this Sep 14, 2021
@cy-by cy-by temporarily deployed to honeycrisp-update-to-pe-7ajbbe September 14, 2021 22:11 Inactive
@cy-by cy-by marked this pull request as ready for review September 14, 2021 22:25
Copy link
Contributor

@bengolder bengolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Colt!

@bengolder bengolder merged commit 4530cc0 into main Sep 14, 2021
@bengolder bengolder deleted the update-to-percy-cli branch September 14, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants