-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gem dependencies that have security risks #298
Conversation
- run: | ||
name: "Configure Bundler" | ||
command: | | ||
echo 'export BUNDLER_VERSION=$(cat Gemfile.lock | tail -1 | tr -d " ")' >> $BASH_ENV | ||
source $BASH_ENV | ||
gem install bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this run
step in each job, install_dependencies
, run_checks
, and run_tests
. If not, bundler v1
would be used and the job would fail.
I'm not really familiar with CircleCI config code, is there a way to define this once for all three jobs to use? So that this code can be DRY?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coltborg I believe that yes, you can define it once and reuse it for all three jobs. I think the GYR circle CI config has examples of defining a command and reusing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you! I'm happy to pair on a followup commit to refactor/DRY the CircleCI config file.
Comes from #296.
What does this PR do?
rails
to5.2.4.6
bundler
to2.2.19
v2
of bundlerTesting
Locally, I'm able to
bundle install
and run the applicationbin/rails s
without issue.I might be a good idea for whoever tests this PR, to pull it down locally and make sure a
bundle install
works properly.