Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - "None of the above" in checkbox set (Breaking) #320

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Mar 5, 2024

Fix for when there are mutiple checkbox sets on one page - the "none of the above" toggle will be applied only to its own set (instead of every checkbox set on the page)

⚠️ Breaking change for folks using id="none__checkbox" without the "input name" appended ex id="none__checkbox-programSelection"

…of the above" toggle will be applied only to its own set
@sree-cfa sree-cfa self-assigned this Mar 5, 2024
@sree-cfa sree-cfa marked this pull request as ready for review March 6, 2024 00:27
@sree-cfa sree-cfa changed the title Fix - "None of the above" in checkbox set Fix - "None of the above" in checkbox set (Breaking) Mar 6, 2024
Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@sree-cfa sree-cfa merged commit 4d31037 into main Mar 6, 2024
4 checks passed
@sree-cfa sree-cfa deleted the fix-checkbox-none branch March 6, 2024 23:40
arinchoi03 added a commit that referenced this pull request May 28, 2024
arinchoi03 added a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants