Improve accessibility of focus state #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinchoi03
force-pushed
the
GCF-271-improve-accessibility-of-focus-state
branch
from
7fbf123 to
5181c29
Compare
… upload/checkbox/radio/select & update outline color generally
arinchoi03
force-pushed
the
GCF-271-improve-accessibility-of-focus-state
branch
from
5181c29 to
d69d31f
Compare
…f illustration is not focusable, this change will not impact that element
…expand region to apply focus outline to the entire button (not just btn text)
arinchoi03
commented
Jun 21, 2024
| display: inline-block; | ||
| width: 48px; | ||
| height: 48px; | ||
| } |
There was a problem hiding this comment.
adding an example of linked image since we didn't have an example of that usage in honeycrisp.
arinchoi03
commented
Jun 21, 2024
| @@ -44,6 +46,7 @@ | |||
| .accordion__content { | |||
| margin-top: $s35; | |||
| display: block; | |||
| padding: 0 $s15 $s15 $s15; | |||
There was a problem hiding this comment.
can talk through these changes if necessary
arinchoi03
commented
Jun 21, 2024
| @@ -67,7 +63,7 @@ label { | |||
| background-color: $color-white; | |||
| border: 2px solid $color-grey-darkest; | |||
| input[type='radio'] { | |||
| @include outline; | |||
| @include outline-with-offset; | |||
There was a problem hiding this comment.
move this up & fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. text input
b. textarea
c. buttons
d. radio buttons
e. checkboxes
f. select
g. reveal
h. link (WITHOUT OFFSET)
aelements (links). We need offset for linked images only. I see examples of linked images on the homepage that have theillustrationclass, so I'll be adding the offset there. For illustrations that do not get focus, this css change will have no impact.