Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an emoji index #64

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Add an emoji index #64

merged 6 commits into from
Jan 29, 2019

Conversation

anule
Copy link
Contributor

@anule anule commented Jan 19, 2019

This PR resolves #24

@anule anule changed the title Add an emoji index [WIP] Add an emoji index Jan 19, 2019
@anule anule force-pushed the emoji-index branch 3 times, most recently from a8f543c to a8694bc Compare January 25, 2019 01:07
@anule anule changed the title [WIP] Add an emoji index Add an emoji index Jan 25, 2019
Copy link
Contributor

@wschaefer-cfa wschaefer-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I have a couple of small comments and a question inline, but overall 🚢 it! :)

@hartsick
Copy link
Contributor

This is great! One small addition to what Whitney said: when you're done with this, could you bump the patch number in version.rb, run bundle install, and commit those changes? That way projects will be able to pick up these additions by updating the gem.

@anule anule merged commit bdf3e79 into master Jan 29, 2019
@anule anule deleted the emoji-index branch January 29, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an emoji index
3 participants