Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a contact should be visually separated from existing contacts #193

Closed
anselmbradford opened this issue Aug 1, 2014 · 2 comments
Closed

Add a contact should be visually separated from existing contacts #193

anselmbradford opened this issue Aug 1, 2014 · 2 comments
Labels
admin

Comments

@anselmbradford
Copy link
Member

screen shot 2014-08-01 at 12 23 29 pm

There should be visual separation between an existing entry and the "Add a contact" entry. As is it appears "Add a contact" is part of the existing entry, so that that is the button that should be clicked to save the added/edited contact info.
@anselmbradford
Copy link
Member Author

Also, the text might be clearer as "Add a new contact"

cndreisbach added a commit to cndreisbach/ohana-api that referenced this issue Aug 2, 2014
@cndreisbach
Added visual indicators between repeated form objects
af30468 
Issue codeforamerica#193 discussed one specific place that the admin interface needed
a visual indicator between buttons. That same pattern repeats itself
throughout the location form, so this commit addresses all of them. In
addition, it gives a visual indicator between each element in a list of
children.
@cndreisbach cndreisbach mentioned this issue Aug 2, 2014
Merged
@monfresh
Copy link
Member

Fixed in PR #206 with an hr. @anselmbradford, feel free to style it differently if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anselmbradford @monfresh