Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV import script should not fail if csv files are empty #284

Closed
pmackay opened this issue Dec 3, 2014 · 1 comment · Fixed by #287
Closed

CSV import script should not fail if csv files are empty #284

pmackay opened this issue Dec 3, 2014 · 1 comment · Fixed by #287
Labels
bug

Comments

@pmackay
Copy link
Contributor

pmackay commented Dec 3, 2014

Testing an import, files with no entries are causing import to fail. This is unlikely in the real world but when testing its quite possible. Should be possible to have some empty files.
@monfresh
Copy link
Member

monfresh commented Dec 3, 2014

You are correct that the import should not fail if files that are not required are empty or missing, but required files should absolutely fail. I will fix the non-required files issue. Thanks for reporting this.

@monfresh monfresh added the bug label Dec 3, 2014
monfresh added a commit that referenced this issue Dec 3, 2014
@monfresh
Ignore CSV files that are not required.
06394f5 
If a CSV file that is not required is either missing or present  but
empty, the import script will skip it and won’t raise an error.

If a required file is missing or empty, then the rake task will be
aborted and an error message will appear explaining that the file is
missing or empty.

Closes #284.
@monfresh monfresh mentioned this issue Dec 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore CSV files that are not required. codeforamerica/ohana-api
2 participants
@pmackay @monfresh