Geocoder::OverQueryLimitError while importing locations, addresses #336
Comments
monfresh
added a commit
that referenced
this issue
May 17, 2015
- Improve logic that determines whether or not a location needs to be geocoded. In addition, the location importer now checks to see if an address already exists for the location. If so, it updates that same address instead of assigning address attributes, which, unbeknown to me, actually destroyed the existing location and created a new one. The side effect of destroying the address is that it triggered the `reset_location_coordinates` callback, which in turn triggered the geocoding since the location no longer had coordinates. - Invalid entries no longer prevent the entire CSV file from being saved to the database. Now, valid entries get saved, and error messages are displayed for invalid entries. - If a CSV file doesn't have sequential IDs, the database will now save the entry with the same ID as in the CSV file. Previously, the database would assign sequential IDs, which would cause mismatches between CSV files that refer to a particular foreign key. - Added a conditional for the `touch_locations` callback in organization.rb to improve performance during initial import of organizations. - The console output that lets you know which file is being imported has been moved out of the rake task and into the EntityImporter. That way, if a file is skipped (because it's not required and is missing or empty, for example), then the console won't say that it is being imported. Closes #336.
monfresh
added a commit
that referenced
this issue
May 17, 2015
- Improve logic that determines whether or not a location needs to be geocoded. In addition, the location importer now checks to see if an address already exists for the location. If so, it updates that same address instead of assigning address attributes, which, unbeknown to me, actually destroyed the existing address and created a new one. The side effect of destroying the address is that it triggered the `reset_location_coordinates` callback, which in turn triggered the geocoding since the location no longer had coordinates. - Invalid entries no longer prevent the entire CSV file from being saved to the database. Now, valid entries get saved, and error messages are displayed for invalid entries. - If a CSV file doesn't have sequential IDs, the database will now save the entry with the same ID as in the CSV file. Previously, the database would assign sequential IDs, which would cause mismatches between CSV files that refer to a particular foreign key. - Added a conditional for the `touch_locations` callback in organization.rb to improve performance during initial import of organizations. - The console output that lets you know which file is being imported has been moved out of the rake task and into the EntityImporter. That way, if a file is skipped (because it's not required and is missing or empty, for example), then the console won't say that it is being imported. Closes #336.
|
Thanks for the report! I fixed this issue, along with the invalid vs valid entries issue you reported in the other closed issue. |
|
Tested this, seems better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm raising this because I've already inserted all the lat/long values into the data, so that geocoding would not be needed. Is there a case where it would be triggered even if the lat/long are present?
The text was updated successfully, but these errors were encountered: