lat_lng search (now with tests) #171
Conversation
| @@ -99,6 +99,7 @@ | |||
| it 'returns no results' do | |||
| create(:farmers_market_loc) | |||
| get 'api/search?location=00000' | |||
| puts json | |||
There was a problem hiding this comment.
Please remove this line (puts json).
|
Thanks, Dana. It looks much better now. There are just a few minor style issues. If you could please fix them, we'll be good to go. See my inline comments. Also, note that you don't have to create a whole new pull request to make these changes. You can just push your new changes to the same branch. If you know how to rebase, that would be ideal so that your commits are squashed into a single one with a more accurate commit message that references the |
… the form lat,lng
|
The only reason I created a new branch was because I wanted to merge in your recent changes, and the rebase didn't go smoothly. So it was easier to just pull your master and then re-cherry-pick the changelist. I made the changes you suggested, and squashed it down to a single commit via rebase. I had to force the push since the changes were already on the remote branch. |
|
Gotcha. Thanks for the changes! You're right about having different expectation syntax in our specs. I'm actually working on fixing that right now. There's a gem that will do it for you: https://github.com/yujinakayama/transpec |
lat_lng search (now with tests)
I made sure that this passes all tests (at least for search - a bunch of the other tests are broken), and added some new tests.
Also, renamed the parameter to lat_lng from geo, which I agree makes more sense.