-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make authentication email addresses customizable #197
Conversation
@@ -68,6 +68,8 @@ generic_domains: | |||
# app/views/admin/organizations/index.html.haml. | |||
admin_support_email: [email protected] | |||
|
|||
# The email address that confirmation emails are sent from after user signup. | |||
confirmation_email: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this to '[email protected]'
. These are the settings for our demo site, and we'd like to have a default value here. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can definitely do, fast question though - it used to be hardcoded to [email protected]
; did you mean that one instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the new one is better. The old one is not an actual email address and we'd like people to send us email if they want to. Thanks for checking though.
Looks good, thanks! Could you also please add a spec for this? You can just add a new expectation in this spec. Something like this: expect(first_email.from).to eq('[email protected]')
reset_email Then define
Thanks! |
Oh, and you'll need to add |
Also set default value in config/settings.yml.
Done and done. Thanks for the pointers. |
Thanks! |
Completes #182.