Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added text for the negative state of a TTY number #202

Merged
merged 2 commits into from
Aug 4, 2014

Conversation

cndreisbach
Copy link

Previously, when adding a phone number, you had the choice of setting
the phone type to a blank line or "TTY". We have clarified this by
changing the choices to "Not a TTY number" or "TTY number". The values
set are the same as previously.

Resolves #196.

Previously, when adding a phone number, you had the choice of setting
the phone type to a blank line or "TTY". We have clarified this by
changing the choices to "Not a TTY number" or "TTY number". The values
set are the same as previously.
@monfresh
Copy link
Member

monfresh commented Aug 3, 2014

Thanks! Could you please update the specs and convert the double quotes into single quotes?

You'll need to:

  • Add if options[:number_type] to the end of this line.
  • Change the value of number_type to TTY number in update_phone_numbers_spec and in create_location_spec.
  • Add a new spec in the feature 'Update phones' section at the bottom of update_phone_number_spec to test that the initial value of the dropdown is Not a TTY number.

Please remember to run script/test to check your work.

@cndreisbach
Copy link
Author

Thanks for the feedback! I've pushed a new commit with all those changes.

@monfresh monfresh merged commit 99f568d into codeforamerica:master Aug 4, 2014
@monfresh
Copy link
Member

monfresh commented Aug 4, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide text for TTY off state
2 participants