Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundle caching on S3 #204

Closed
wants to merge 1 commit into from

Conversation

cndreisbach
Copy link

Travis does not yet support caching your bundle for public projects.
Still, I've removed bin/wad, as it wasn't working, and a slow Travis
run is better than no Travis run.

Addresses issue #203.

Travis does not yet support caching your bundle for public projects.
Still, I've removed `bin/wad`, as it wasn't working, and a slow Travis
run is better than no Travis run.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bc99de4 on cndreisbach:unwad into 454daf3 on codeforamerica:master.

@monfresh
Copy link
Member

monfresh commented Aug 2, 2014

The builds are failing because the wad script uses encrypted env vars on Travis, which are disabled for PRs from forks for security reasons. These recent PRs are the first external ones we've received since adding the wad script a while back, so I had forgotten about this issue. Travis runs fine for internal PRs.

I'd still like to keep using the script since we don't get that many external PRs (versus internal ones), and I think I can avoid having to provide my S3 credentials by allowing anonymous downloads for my bucket. I'll investigate and report back.

@cndreisbach
Copy link
Author

Cool. That makes sense.
On Aug 2, 2014 6:49 PM, "Moncef Belyamani" [email protected] wrote:

The builds are failing because the wad script uses encrypted env vars on
Travis, which are disabled for PRs from forks for security reasons. These
recent PRs are the first external ones we've received since adding the wad
script a while back, so I had forgotten about this issue. Travis runs fine
for internal PRs.

I'd still like to keep using the script since we don't get that many
external PRs (versus internal ones), and I think I can avoid having to
provide my S3 credentials by allowing anonymous downloads for my bucket.
I'll investigate and report back.


Reply to this email directly or view it on GitHub
#204 (comment)
.

@monfresh
Copy link
Member

monfresh commented Aug 4, 2014

I fixed this in PR #211. Closing this. Please do a git pull if you're planning on sending more PRs, and thanks a lot for all your contributions so far!

@monfresh monfresh closed this Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants