Highlight fields with errors & update validations. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #188. Rails automatically surrounds a field that failed to pass validations with a div that has a class called `field_with_errors`. For some reason, this doesn’t get added to serialized fields, so I had to write custom methods in `form_helper.rb`. I also updated the HTML for some of the fields so that the highlighted field would retain the same appearance as the regular field. While working on this, I realized some of the model validations could be refactored and simplified.
monfresh
added a commit
that referenced
this pull request
Sep 4, 2014
Highlight fields with errors & update validations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188.
Rails automatically surrounds a field that failed to pass validations
with a div that has a class called
field_with_errors. For somereason, this doesn’t get added to serialized fields, so I had to write
custom methods in
form_helper.rb.I also updated the HTML for some of the fields so that the highlighted
field would retain the same appearance as the regular field.
While working on this, I realized some of the model validations could
be refactored and simplified.