Add support for searching on multiple languages. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: http://ohana-api-demo.herokuapp.com/api/search?language[]=Filipino%20(Ta galog)&language[]=Hindi This will return locations whose languages field contain either “Filipino (Tagalog)” OR “Hindi”. Run `bin/rake db:migrate` to update the DB. This PR converts the `languages` field from text to the Postgres Array type. If for some reason you want to rollback this DB change, you’ll first need to add the following line in `app/models/location.rb`: ``` serialize :languages, Array ``` Then you can rollback: ``` bin/rake db:rollback ``` You’ll then need to update the `language` search method to its previous query, and update `spec/api/search/language_spec.rb`.
monfresh
added a commit
that referenced
this pull request
Sep 9, 2014
…ages Add support for searching on multiple languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
https://ohana-api-demo.herokuapp.com/api/search?language%5B%5D=Filipino%20(Tagalog)&language%5B%5D=Hindi
This will return locations whose languages field contains either
“Filipino (Tagalog)” OR “Hindi”.
If you've already installed this app and populated your DB with languages, run
bin/rake db:migrateto update the DB. This PR converts thelanguagesfield from text to the Postgres Array type.If for some reason you want to rollback this DB change, you’ll first
need to add the following line in
app/models/location.rb:Then you can rollback:
You’ll then need to update the
languagesearch method to its previousquery, and update
spec/api/search/language_spec.rb.