Fixes #25 and #26 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the invalid params tests to actually test invalid scenarios and fixed the create, delete, and redirect on create specs by using "reload"
The Rails scaffold generator creates a few unnecessary actions and files. One of them is the "show" action that just shows the information. A user must then click the "Edit" link to be able to update the application. I think it's a better experience for the user to be taken directly to the edit mode when they click on one of their applications.
Otherwise, bad things will happen, such as having a higher number of remaining requests than the limit.
anselmbradford
added a commit
that referenced
this pull request
Jun 22, 2013
skasch
pushed a commit
to skasch/ohana-api
that referenced
this pull request
Feb 7, 2015
animista01
pushed a commit
to IOfoundation/ohana-api
that referenced
this pull request
May 19, 2020
CS-833 Ohana changes to support Location form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers can now sign up for an account (email is required and has to be confirmed), and can register applications. When an application is registered, a random API token is automatically generated and displayed.
The rate limiter now checks for an
X-API-Tokenheader with a token that matches one belonging to a registered application. If it finds it, then it grants the application 5000 requests per hour. Otherwise, the client gets 60 requests per hour.