-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeCov shield for create react app #631
Conversation
af60fee
to
cea80fe
Compare
933ee76
to
b013781
Compare
to see the shield working in practice checkout my dev branch: Otherwise the shield will say unknown until the commit is accepted and the test suite passes again. |
Sorry, hectic times for me. If no one else manages to catch this sooner, I'll run this over when I get a chance! Thanks! |
b013781
to
98c54d1
Compare
Looks good. I would probably leave out the This would certainly be nice to have though, now that we have people working on tests. |
@MichaelDimmitt : Thoughts on the |
@wacii, @knod,
|
Alright, I think I misunderstood exactly how this works. It is jest that collects the coverage information, the I was assuming the My preference would be for PR #632, but this one is fine too. |
@wacii, I too am a fan of #632, FYI, when a test fails in react-scripts test -- --coverage Wanted to give a headsup. In case someone uses the coverage command for a failing test suite. Added documentation to the project, here |
I will be adding to the documentation for this pull request after it has been merged or closed. To improve readability of the process for setting code coverage up on a create react app.
link1: code coverage from create react app issues page
link2: code coverage from create react app docs
link3: use yarn test instead of npm test
Lastly, codecov needed to be installed to get the shield.
Codecov is a global npm package installed when running TravisCI or CircleCI that hosts your previous and current code coverage information to show the projects progression over time.
Running codecov after the files have been written to the coverage folder, sends the coverage folder info to the codecov website. This service is free for open source projects.