Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1546] Add e2e tests for Browse Testimonies page #1580

Merged

Conversation

seatuna
Copy link
Collaborator

@seatuna seatuna commented Jul 9, 2024

Summary

This PR adds e2e tests for the Browse Testimonies page per this issue: #1546

Success Criteria

  • Playwright test covering the Browse Testimonies page, including:
  • Able to find Testimony via Text Search
  • Able to sort Testimonies as expected
  • Able to filter Testimonies as expected (via facets in left sidebar)
  • Able to filter Testimonies from All / Individuals / Orgs (via tabs at top of page)
  • Able to click a Testimony and successfully navigate to the Testimony Detail page for that testimony
    This addresses a specific bug we encountered in the generation of links to testimony detail pages

Screenshots

Screen Shot 2024-07-09 at 3 26 13 PM

Known issues

  • I had to increase the default timeout for tests to decrease flakiness for Firefox tests due to Firefox tests running slower than Chrome. This is a known issue: [Question] Performance issues on Firefox? microsoft/playwright#1396
  • My laptop is too old and can't upgrade to a compatible version of webkit, so the tests were only run against Chrome and Firefox.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 9:06pm

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM!

@Mephistic Mephistic merged commit c0f6bb6 into codeforboston:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants