Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the IBM i Project Explorer and Source Orbit extension #7

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

SanjulaGanepola
Copy link
Member

No description provided.

@edmundreinhardt
Copy link

I have been looking forward to this PR for some time. Is there any concerns?

@SanjulaGanepola SanjulaGanepola changed the title Add the IBM i Project Explorer extension Add the IBM i Project Explorer and Source Orbit extension Oct 22, 2024
Signed-off-by: Sanjula Ganepola <[email protected]>
@edmundreinhardt
Copy link

@worksofliam could we approve and merge?
@ThePrez was asking for this yesterday

@edmundreinhardt
Copy link

Any updates? Can we approve. We wll be talking Source Orbit and IBM i Project explorer multiple times as the Navigate conference and it would nice to have the Development Pak seal of approval. Are there any blockers?
@worksofliam

@worksofliam
Copy link
Contributor

Since @SanjulaGanepola confirmed with me that the library list doesn't get disabled unless iproj.json is created I think it could be merged.

What do you think @sebjulliand?

@edmundreinhardt
Copy link

@sebjulliand Hi Seb, do you have an objection to merging this PR?

@edmundreinhardt
Copy link

@sebjulliand Sorry to be a pain, just looking for some response on this

@sebjulliand
Copy link

Sorry about the delay @edmundreinhardt ; so if Project Explorer doesn't interfer with anything unless an i Project is open, I don't have any object to have it included in the dev pack 👍🏻

Copy link

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AIforIBMi
Copy link

@worksofliam we have approval, can we merge this PR now?

@worksofliam worksofliam merged commit 217d596 into codefori:master Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants