-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the IBM i Project Explorer
and Source Orbit
extension
#7
Conversation
I have been looking forward to this PR for some time. Is there any concerns? |
Signed-off-by: Sanjula Ganepola <[email protected]>
IBM i Project Explorer
extensionIBM i Project Explorer
and Source Orbit
extension
Signed-off-by: Sanjula Ganepola <[email protected]>
@worksofliam could we approve and merge? |
Any updates? Can we approve. We wll be talking Source Orbit and IBM i Project explorer multiple times as the Navigate conference and it would nice to have the Development Pak seal of approval. Are there any blockers? |
Since @SanjulaGanepola confirmed with me that the library list doesn't get disabled unless iproj.json is created I think it could be merged. What do you think @sebjulliand? |
@sebjulliand Hi Seb, do you have an objection to merging this PR? |
@sebjulliand Sorry to be a pain, just looking for some response on this |
Sorry about the delay @edmundreinhardt ; so if Project Explorer doesn't interfer with anything unless an i Project is open, I don't have any object to have it included in the dev pack 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@worksofliam we have approval, can we merge this PR now? |
No description provided.