Build/debug improvements

[sebjulliand]

Changes

• Replaced ts-loader by esbuild-loader for faster build times (went from 3 seconds to 700 milliseconds here)
• Run webpack-dev as the prelaunch task when starting debug for a more convenient debugging experience

Checklist

• have tested my change
• eslint is not complaining

[chrjorgensen]

@sebjulliand Curious as I am I saw your change and wanted to try it out - but after running npm i and pressing F5 to test / debug, I get the following error:

Am I doing something wrong?

[chrjorgensen]

I'm on Windows 64-bit and not on Mac - could that be the problem?

[sebjulliand]

Thanks for giving it a try @chrjorgensen !
Actually, I'm on Windows (10) 64 bits too and it works fine. I even started from scratch (using git clean -xdf to wipe everything).

Can you check what you have under the node_modules/@esbuild folder?
I have this here:

[chrjorgensen]

@sebjulliand Not sure what happened but now it works...? I did nothing except for checking out another PR, checkout master and checkout this PR and npm i - and now I got the win32-x64 version of esbuild.

[chrjorgensen]

This is incredibly fast now to start the extension debug!! Wow!

[sebjulliand]

This is incredibly fast now to start the extension debug!! Wow!

That's great, i'm glad it's working for you now! What I like with having the debug in watch mode is that you don't need to restart the debug after making modifications. Hitting ctrl+r in the debug window reloads it right away.

[worksofliam]

This is no joke! It is incredibly fast. Here's the last issue I'm facing with this.

When I start to debug:

And this error appears in the tasks.json:

Any ideas?

[worksofliam]

Issue with tasks.json.

[sebjulliand]

Darn, I didn't face that issue. I'll have a look asap. In the meantime , can you try running 'git clean -xdf' to wipe everything and then start from scratch with 'npm i' and retry debugging ? Le dim. 19 mars 2023, 00:37, barry ***@***.***> a écrit :

…

***@***.**** requested changes on this pull request. Issue with tasks.json. — Reply to this email directly, view it on GitHub <#1135 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUVGOUQXWHHWMHC76XTEHLW4ZBMVANCNFSM6AAAAAAV25PLWQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[worksofliam]

@sebjulliand Looks like installing this extension fixed it for me:

Perhaps this PR should also add it to the .vscode/extensions.json file?

[sebjulliand]

Good point @worksofliam !
I guess that extension made its way to my VSCode somehow. I added it as you suggested.
Feel free to merge whenever you feel like it's OK.

[worksofliam]

Will merge after some other important PRs I think.