Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quick Connect #1150

Merged
merged 12 commits into from
Apr 11, 2023
Merged

Add Quick Connect #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
af03505
Add Quick Connect
chrjorgensen Mar 21, 2023
2d1dc79
Delete cached server settings when deleting connection
chrjorgensen Mar 21, 2023
0c4637e
Add connect and reload option in connection right-click
chrjorgensen Mar 25, 2023
500c1cd
Make server settings cache key a function
chrjorgensen Mar 25, 2023
b748a50
Fix parenthesis error in deleteServerSettingsCache
chrjorgensen Apr 3, 2023
0681556
Check for match of remote features keys and cache
chrjorgensen Apr 3, 2023
8df637f
Clarify empty code block
chrjorgensen Apr 7, 2023
4c82cfb
Make Quick Connect active by default
chrjorgensen Apr 7, 2023
0b9b42b
Clarify how to connect and reload server settings
chrjorgensen Apr 7, 2023
f8469c7
Initialize new config parameters in settings view
chrjorgensen Apr 11, 2023
fb6adfb
Fix update of current config
chrjorgensen Apr 11, 2023
dc67986
Fix optional parameter in call to 'connect'
chrjorgensen Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,11 @@
"category": "IBM i",
"icon": "$(remote)"
},
{
"command": "code-for-ibmi.connectToAndReload",
"title": "Connect and Reload Server Settings",
"category": "IBM i"
},
{
"command": "code-for-ibmi.refreshConnections",
"title": "Refresh Connections",
Expand Down Expand Up @@ -1520,6 +1525,10 @@
"command": "code-for-ibmi.connectToPrevious",
"when": "never"
},
{
"command": "code-for-ibmi.connectToAndReload",
"when": "never"
},
{
"command": "code-for-ibmi.disconnect",
"when": "code-for-ibmi:connected"
Expand Down Expand Up @@ -1727,6 +1736,11 @@
"when": "view == connectionBrowser && viewItem == server",
"group": "inline"
},
{
"command": "code-for-ibmi.connectToAndReload",
"when": "view == connectionBrowser && viewItem == server",
"group": "3_connect@1"
},
{
"command": "code-for-ibmi.moveLibraryUp",
"when": "view == libraryListView && viewItem == library",
Expand Down
4 changes: 3 additions & 1 deletion src/api/Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export namespace ConnectionConfiguration {
debugUpdateProductionFiles: boolean;
debugEnableDebugTracing: boolean;
readOnlyMode: boolean;
quickConnect: boolean;
[name: string]: any;
}

Expand Down Expand Up @@ -119,7 +120,8 @@ export namespace ConnectionConfiguration {
debugIsSecure: (parameters.debugIsSecure === true),
debugUpdateProductionFiles: (parameters.debugUpdateProductionFiles === true),
debugEnableDebugTracing: (parameters.debugEnableDebugTracing === true),
readOnlyMode: (parameters.readOnlyMode === true)
readOnlyMode: (parameters.readOnlyMode === true),
quickConnect: (parameters.quickConnect === true || parameters.quickConnect === undefined)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it shows that Quick Connect will be on by default.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam Yeah, Quick Connect was changed to be the default behavior with the setting available for the user to opt-out - per our discussion two weeks ago. Hope this is okay?

}
}

Expand Down
Loading