Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local actions to download directories post build #1154

Merged
merged 7 commits into from
Mar 25, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Mar 22, 2023

Changes

Now both files and directories can be downloaded as part of a local build.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam marked this pull request as ready for review March 23, 2023 01:04
@worksofliam worksofliam requested a review from sebjulliand March 23, 2023 01:04
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change to consider. Otherwise, it's great!

@worksofliam worksofliam requested a review from sebjulliand March 25, 2023 19:13
sebjulliand
sebjulliand previously approved these changes Mar 25, 2023
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, but that's me being picky 😅

src/schemas/actions.json Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Julliand <[email protected]>
@worksofliam
Copy link
Contributor Author

@sebjulliand thanks! I'm gonna merge now.

@worksofliam worksofliam merged commit 2ca808d into master Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants