Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbt/adapters/sqlite/__version__.py #12

Closed
edgarrmondragon opened this issue Dec 8, 2021 · 1 comment
Closed

Add dbt/adapters/sqlite/__version__.py #12

edgarrmondragon opened this issue Dec 8, 2021 · 1 comment

Comments

@edgarrmondragon
Copy link
Contributor

edgarrmondragon commented Dec 8, 2021

Adding the file with a variable version set to the package version allows printing the adapter version along when dbt --version is invoked.

Current behavior:

$ dbt --version
installed version: 1.0.0
   latest version: 1.0.0

Up to date!

Plugins:

Expected behavior:

$ dbt --version
installed version: 1.0.0
   latest version: 1.0.0

Up to date!

Plugins:
  - sqlite: 0.2.2

Reference: https://docs.getdbt.com/docs/contributing/building-a-new-adapter#__version__py

codeforkjeff added a commit that referenced this issue Dec 8, 2021
@codeforkjeff
Copy link
Owner

Thank you for catching this! I've committed the change.

The docs for building a new adapter have been updated quite a bit since I last looked at them. I should review it again and see if there's anything else I should add, then I'll make a new release. Hopefully I'll get to it in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants