Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #30: Improve type handling #36

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Conversation

codeforkjeff
Copy link
Owner

@codeforkjeff codeforkjeff commented Jan 17, 2023

Resolves issue #30

  • The convert functions in SQLiteAdapter now all return recognized affinities in SQLite.
  • get_columns_in_relation() used to report a column's type as TEXT if SQLite didn't report any type affinity for the column. I think this was in place to make incremental models work. I changed this to UNKNOWN because that's less misleading. This is what will show up for column types in dbt-generated docs.
  • Add notes to test_data_types about how types work in SQLite and do the best we can in those tests.

@codeforkjeff codeforkjeff merged commit 0a64272 into main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant