Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use YAML objects instead of colon-separated strings #8

Merged

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented May 9, 2021

The use of a colon-separated string can be hard to read when there are more than a few datafiles:

schemas_and_paths: 'main=/my_project/data/main.db;source1=/my_project/data/source1.db;source2=/my_project/data/source2.db'

Using a YAML object should allow users to define the file-schema mapping in a friendlier way:

schemas_and_paths:
  main: /my_project/data/main.db
  source1: /my_project/data/source1.db
  source2: /my_project/data/source2.db

A similar thing happens with SQLite extensions:

extensions:
  - /path/to/sqlite-digest/digest.so

I've tested this locally with pytest test/sqlite.dbtspec and the 9 tests pass.

btw @codeforkjeff, thanks for creating this project!

Replace colon-separated schema mapping with a YAML object.
@codeforkjeff codeforkjeff merged commit 0216134 into codeforkjeff:main Jul 8, 2021
@codeforkjeff
Copy link
Owner

Thank you so much for this! This is a really good improvement. Apologies again that it has taken me so long to look at this, I really appreciate your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants