Quiz #1229
Open
Quiz #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still working on percentage issue - increments when all correct answers are selected from 75% to 100%, should just display 100% when component is loaded
Hey, I'm having a small bug on the ResultsComponent - seems to be incrementing the percentage from 75 to 100% when all the questions are answered correctly, should just show 100% and also 100% in the queryparams in the URL. Also the images are kind of slow to load.
made some changes to the question container component
I think I fixed the issue where a navigation error occurs when ResultsComponent seems to navigate away back to quiz/question/id after a minute or so when id is greater than the totalQuestions.
Moved the percentage calculation to ngOnInit in ResultsComponent which fixes the issue of it updating. Will look into violation errors...
Moved the percentage calculation to ResultsComponent in ngOnInit. Will work on the violations...
used ceil function for elapsedTime and changed the calculateTotalElapsedTime function
added percent symbol inside href's in the challenge-social section
utilized API function to reduce the conditionals
removed comments and spacing
Changed from queryParams to state. Relevant data gets passed from containers\QuestionComponent to ResultsComponent via state object when navigating to results, resulting in clean URL for the /quiz/results route.
Changed from queryParams to state. Relevant data gets passed from containers\QuestionComponent to ResultsComponent via state object when navigating to results, resulting in clean URL for the /quiz/results route.
added more questions back so now there are 10 questions (to see how it works for testing purposes...)
added a dynamic accordion to ResultsComponent using ngx-bootstrap which opens one question at a time individually in an accordion-group tab
individual questions inside accordion can be expandable/collapsable with chevron up and down icons
added addElapsedTime function and used destructuring for elapsedTimes
added the addElapsedTime function and used destructuring for elapsedTImes array
kirjs
requested changes
Feb 13, 2020
apps/playground/src/app/quiz/containers/question/question.component.ts
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/question/question.component.ts
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/question/question.component.ts
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/question/question.component.ts
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/question/question.component.ts
Outdated
Show resolved
Hide resolved
kirjs
reviewed
Feb 13, 2020
apps/playground/src/app/quiz/containers/results/results.component.html
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/results/results.component.html
Outdated
Show resolved
Hide resolved
apps/playground/src/app/quiz/containers/results/results.component.ts
Outdated
Show resolved
Hide resolved
kirjs
reviewed
Feb 27, 2020
...und/src/app/quiz/containers/dependency-injection-quiz/dependency-injection-quiz.component.ts
Outdated
Show resolved
Hide resolved
kirjs
reviewed
Feb 27, 2020
...und/src/app/quiz/containers/dependency-injection-quiz/dependency-injection-quiz.component.ts
Outdated
Show resolved
Hide resolved
kirjs
reviewed
Feb 27, 2020
...und/src/app/quiz/containers/dependency-injection-quiz/dependency-injection-quiz.component.ts
Outdated
Show resolved
Hide resolved
…eries will continue to work on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kirill,
I've added a quiz branch (https://github.com/marvinrusinek/codelab/tree/quiz). Please can you take a look at it and let me know if anything needs to be changed.
Marvin