Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check all btn #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add check all btn #87

wants to merge 2 commits into from

Conversation

amitmbee
Copy link
Contributor

@amitmbee amitmbee commented Apr 3, 2018

Adds a checkbox as column header which allows the user to check/uncheck all the requests for interception at once

Copy link
Contributor

@revathskumar revathskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the implementation needs much more effort. will discuss this.

Header : (data) =>
<input type="checkbox" className="checkAll" onChange={e =>
data.data.forEach( (val) => e.target.checked ?
props.handleCheckToggle(val._original.requestId, true) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is method call in forEach?

@@ -55,9 +55,16 @@ const RequestList = (props: RequestObj) => {
},
{
id: "checkbox",
accessor: "",
Header : (data) =>
<input type="checkbox" className="checkAll" onChange={e =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to determine if the checkbox is checked or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants